Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade BSP to geth-v1.13.15 #235

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Upgrade BSP to geth-v1.13.15 #235

merged 6 commits into from
Jan 10, 2025

Conversation

noslav
Copy link
Member

@noslav noslav commented Jan 10, 2025

No description provided.

rjl493456442 and others added 6 commits April 17, 2024 07:22
* eth/protocols/snap: skip retrieval for completed storages

* eth/protocols/snap: address comments from peter

* eth/protocols/snap: add comments
This PR adds a limit of 1000 to the "inner" topics in a filter-criteria
…mplement gentrie (#29313)

This pull request defines a gentrie for snap sync purpose.

The stackTrie is used to generate the merkle tree nodes upon receiving a state batch. Several additional options have been added into stackTrie to handle incomplete states (either missing states before or after).

In this pull request, these options have been relocated from stackTrie to genTrie, which serves as a wrapper for stackTrie specifically for snap sync purposes.

Further, the logic for managing incomplete state has been enhanced in this change. Originally, there are two cases handled:

-    boundary node filtering
-    internal (covered by extension node) node clearing

This changes adds one more:

- Clearing leftover nodes on the boundaries.

This feature is necessary if there are leftover trie nodes in database, otherwise node inconsistency may break the state healing.
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 72.63682% with 55 lines in your changes missing coverage. Please review.

Project coverage is 53.75%. Comparing base (6aee7ba) to head (37f0a27).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
eth/protocols/snap/sync.go 55.91% 31 Missing and 10 partials ⚠️
eth/protocols/snap/gentrie.go 93.58% 5 Missing ⚠️
eth/filters/api.go 0.00% 2 Missing and 2 partials ⚠️
internal/testrand/rand.go 69.23% 4 Missing ⚠️
core/state/snapshot/conversion.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #235      +/-   ##
===========================================
+ Coverage    53.72%   53.75%   +0.02%     
===========================================
  Files          711      713       +2     
  Lines        91105    91166      +61     
===========================================
+ Hits         48948    49003      +55     
  Misses       37931    37931              
- Partials      4226     4232       +6     
Files with missing lines Coverage Δ
core/rawdb/accessors_chain.go 61.38% <100.00%> (ø)
core/state/statedb.go 70.02% <100.00%> (-0.09%) ⬇️
params/version.go 39.13% <ø> (ø)
trie/stacktrie.go 90.58% <100.00%> (+5.82%) ⬆️
core/state/snapshot/conversion.go 55.38% <75.00%> (+0.28%) ⬆️
eth/filters/api.go 52.45% <0.00%> (-0.66%) ⬇️
internal/testrand/rand.go 69.23% <69.23%> (ø)
eth/protocols/snap/gentrie.go 93.58% <93.58%> (ø)
eth/protocols/snap/sync.go 74.32% <55.91%> (-0.42%) ⬇️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2435e7c...37f0a27. Read the comment docs.

@noslav noslav merged commit 55ac62b into develop Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants